Add missing directory creation step for going_modular#1264
Open
jalateras wants to merge 1 commit intomrdbourke:mainfrom
Open
Add missing directory creation step for going_modular#1264jalateras wants to merge 1 commit intomrdbourke:mainfrom
jalateras wants to merge 1 commit intomrdbourke:mainfrom
Conversation
Add os.makedirs step before first %%writefile command to ensure going_modular directory exists before writing Python scripts to it. This prevents FileNotFoundError when users follow the notebook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a missing step in the PyTorch going modular documentation where the going_modular directory needs to be created before writing Python scripts to it.
Changes
Impact
Users can now successfully follow the notebook without encountering directory creation errors when the %%writefile commands execute.