Skip to content

WebGPURenderer: Rename Nodes to NodeManager#32786

Merged
sunag merged 1 commit intomrdoob:devfrom
sunag:dev-rename-2
Jan 18, 2026
Merged

WebGPURenderer: Rename Nodes to NodeManager#32786
sunag merged 1 commit intomrdoob:devfrom
sunag:dev-rename-2

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Jan 18, 2026

Description

We already have a file called Nodes.js used for exporting the Nodes, which can cause conflicts when referencing files or classes.
The new name NodeManager should preserve the functionality of the class.

@sunag sunag added this to the r183 milestone Jan 18, 2026
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 355.82
84.56
355.82
84.56
+0 B
+0 B
WebGPU 621.5
172.57
621.5
172.57
+0 B
+0 B
WebGPU Nodes 620.1
172.33
620.1
172.33
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 488.06
119.45
488.06
119.45
+0 B
+0 B
WebGPU 691.97
187.85
691.97
187.85
+0 B
+0 B
WebGPU Nodes 641.77
175.02
641.77
175.02
+0 B
+0 B

@sunag sunag marked this pull request as ready for review January 18, 2026 17:30
@sunag sunag merged commit bfdbcf7 into mrdoob:dev Jan 18, 2026
10 checks passed
@sunag sunag deleted the dev-rename-2 branch January 18, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant