Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 31, 2026

Fixed #32903.

Description

Instead of checking just the version, we now keep track of the current ID of the buffer attribute the wireframe attribute is linked to.

I did not want to introduce a new property for this in BufferAttribute or a separate WeakMap in renderers/common/Geometries.js so the tracked ID is stored in a super-private property __id.

Bildschirmaufnahme.2026-01-31.um.10.16.53.mov

@Mugen87 Mugen87 added this to the r183 milestone Jan 31, 2026
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 359.21
85.29
359.21
85.29
+0 B
+0 B
WebGPU 623.28
173.16
623.38
173.17
+102 B
+18 B
WebGPU Nodes 621.86
172.91
621.96
172.93
+102 B
+18 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 490.47
119.49
490.47
119.49
+0 B
+0 B
WebGPU 689.94
186.32
690.04
186.36
+102 B
+36 B
WebGPU Nodes 639.32
173.74
639.43
173.77
+102 B
+29 B

@Mugen87 Mugen87 merged commit 1251d16 into mrdoob:dev Jan 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wireframe caching in getWireframeAttribute fails to update with geometryIndex.version

1 participant