Cleanup generateMipmaps #32915
Merged
Cleanup generateMipmaps #32915
+0
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason to have a cube-array path. Compat mode does not support cube-array and core mode will always use the 2d-array path.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
approved these changes
Feb 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #32903
Description
There's no reason to have a cube-array path for generateMipmaps. Compat mode does not support cube-array and core mode will always use the 2d-array path.
When I copied this code from webgpu-utils, I noticed that the code for cube-array was indexing the
faceMatarray bybaseArrayLayerwhich didn't make sense to me. In the three.js PR I changed it tobaseArrayLayer % 6. But then I went back and try to figure out why tests were passing in webgpu-utils. I finally realized this path is never used 😅. I deleted it there and now this PR deletes it here.