NodeMaterialObserver: track renderId per render object instead observer #32927
+5
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #32926
NodeMaterialObserver: track renderId per render object instead of per observer
Multiple render objects sharing the same observer (same cache key) would
incorrectly skip geometry updates because the first object processed would
set the shared renderId, causing subsequent objects to fall through to
equals() which only checked attribute.version, not actual attribute identity.
When setAttribute()/setIndex() replaces an attribute with a new object
that has the same version number, the cache incorrectly treated it as
unchanged, causing GPU buffer creation to be skipped and a crash on render.
Changes: