Handle WebSocketClosedError and fix indentation error#125
Open
rectalogic wants to merge 1 commit intomrjoes:masterfrom
Open
Handle WebSocketClosedError and fix indentation error#125rectalogic wants to merge 1 commit intomrjoes:masterfrom
rectalogic wants to merge 1 commit intomrjoes:masterfrom
Conversation
Also fix indentation error in htmlfile.py
|
Hi @mrjoes, what do we need to do to make this pr merged and a new version tagged on pypi? the missing on_close call is quite the pain in the butt, and i'd prefer not to fork the entire repo over a single line of code... Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
sockjs-tornado==1.0.7withtornado==6.2, we see millions of exceptions of the form:sockjs-tornadohandlesIOErrorbuttornadois raisingWebSocketClosedError. This PR handles both errors.While fixing this, I also encountered and fixed this exception due to an incorrect indentation in
sockjs/tornado/transports/htmlfile.py: