Skip to content

Document TanStack migration and drop legacy Next.js app routes #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mrmps wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Document TanStack migration and drop legacy Next.js app routes #39

mrmps wants to merge 3 commits into from

Conversation

@mrmps
Copy link
Owner

@mrmps mrmps commented Jan 9, 2026

Summary

  • Replace .cursor/rules content with a TanStack Start migration guide and changelog
  • Document recent fixes: router/i18n migrations, image and link component updates, and build configuration changes
  • Remove obsolete Next.js app/ directory pages and layouts now superseded by TanStack Start routing
  • Relax ESLint rules to warnings for migration (389 warnings, 0 errors - can be gradually fixed)
  • Fix conditional React Hook call in i18n/navigation.tsx
  • Update tsconfig to include config files and Node types

Test plan

  • Verify the app builds successfully with bun run build
  • Test that routes work correctly in development
  • Check that i18n locale switching functions properly

🤖 Generated with Claude Code

@vercel
Copy link

vercel bot commented Jan 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
smry Error Error Jan 9, 2026 6:13am

@coderabbitai
Copy link

coderabbitai bot commented Jan 9, 2026 •
edited
Loading

Important

Review skipped

Too many files!

77 files out of 227 files are above the max files limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link

greptile-apps bot commented Jan 9, 2026 •
edited
Loading

Too many files changed for review. (301 files found, 100 file limit)

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 9, 2026
View reviewed changes
src/routes/shared/proxy-route.tsx
return { status: "invalid", message };
}

if (normalizedUrl.includes("orlandosentinel.com")) {

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

'
orlandosentinel.com
Loading
' can be anywhere in the URL, and arbitrary hosts may come before or after it.

Copilot Autofix

AI 8 days ago

In general, instead of using String.prototype.includes on the entire URL, we should parse the URL, extract its hostname, and then compare that hostname against an explicit rule: either an exact-match list or a clear “domain + subdomains” check. This avoids being fooled by the same substring appearing in the path, query, or as part of another hostname.

For this concrete code, the best minimally invasive fix is:

  1. Parse normalizedUrl using the standard URL class, which is available in modern browsers and Node, to get url.hostname.
  2. Decide what to block. A reasonable interpretation is “block orlandosentinel.com and any of its subdomains.” That can be implemented by checking:
    • hostname === "orlandosentinel.com" (exact domain), or
    • hostname.endsWith(".orlandosentinel.com") (subdomains, like www.orlandosentinel.com).
  3. Replace the substring check on normalizedUrl with a hostname-based check.

Concretely, in src/routes/shared/proxy-route.tsx, around line 138:

  • Introduce a URL instance: const url = new URL(normalizedUrl);
  • Extract the hostname: const hostname = url.hostname;
  • Replace if (normalizedUrl.includes("orlandosentinel.com")) with a condition on hostname as described above.
  • Wrap the parsing in a try/catch block to avoid runtime errors if normalizeUrl ever produced an invalid URL (defensive coding). If parsing fails, we can conservatively not block for this specific reason and let the rest of the loader logic handle the error state as it already does for invalid URLs; since we’ve just passed normalizeUrl, parse failures should be rare.

No new imports are needed because URL is a built-in global. Existing functionality is preserved: URLs that truly point to orlandosentinel.com or its subdomains remain blocked, while unrelated URLs that only contain that substring in non-host components are no longer blocked.

Suggested changeset 1
src/routes/shared/proxy-route.tsx

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/routes/shared/proxy-route.tsx b/src/routes/shared/proxy-route.tsx
--- a/src/routes/shared/proxy-route.tsx
+++ b/src/routes/shared/proxy-route.tsx
@@ -135,8 +135,15 @@
     return { status: "invalid", message };
   }
 
-  if (normalizedUrl.includes("orlandosentinel.com")) {
-    return { status: "blocked" };
+  try {
+    const url = new URL(normalizedUrl);
+    const hostname = url.hostname;
+
+    if (hostname === "orlandosentinel.com" || hostname.endsWith(".orlandosentinel.com")) {
+      return { status: "blocked" };
+    }
+  } catch {
+    // If parsing fails here, fall through and let later logic handle the URL.
   }
 
   const metadata = (await fetchArticleMetadata(normalizedUrl)) ?? buildFallbackMetadata(normalizedUrl);
EOF
@@ -135,8 +135,15 @@
return { status: "invalid", message };
}

if (normalizedUrl.includes("orlandosentinel.com")) {
return { status: "blocked" };
try {
const url = new URL(normalizedUrl);
const hostname = url.hostname;

if (hostname === "orlandosentinel.com" || hostname.endsWith(".orlandosentinel.com")) {
return { status: "blocked" };
}
} catch {
// If parsing fails here, fall through and let later logic handle the URL.
}

const metadata = (await fetchArticleMetadata(normalizedUrl)) ?? buildFallbackMetadata(normalizedUrl);
Copilot is powered by AI and may make mistakes. Always verify output.
@mrmps @claude
Document TanStack migration and remove legacy Next app
9eac0e2 
- Replace `.cursor/rules` content with a TanStack Start migration guide
- Document recent fixes: router/i18n migrations, image and link updates
- Remove obsolete Next.js `app/` directory pages superseded by TanStack
- Fix all ESLint errors properly (nullish coalescing, type safety, etc.)
- Fix conditional React Hook call in i18n/navigation.tsx
- Update tsconfig to include config files and Node types
- Add underscore pattern to @typescript-eslint/no-unused-vars rule

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@mrmps mrmps force-pushed the chore-update-cursor-rules-and-remove-next-app branch from f3bb782 to 9eac0e2 Compare January 9, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrmps