Skip to content

perf: Use static_cast for shadow node #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrousavy merged 2 commits into from
Jan 23, 2026
Merged

perf: Use static_cast for shadow node #1180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56478a1
perf: Use `static_cast` for shadow node
mrousavy Jan 23, 2026
c055997
static-cast concrete state
mrousavy Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nitrogen/src/views/CppHybridViewComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ namespace ${namespace} {
void ${descriptorClassName}::adopt(react::ShadowNode& shadowNode) const {
// This is called immediately after \`ShadowNode\` is created, cloned or in progress.
// On Android, we need to wrap props in our state, which gets routed through Java and later unwrapped in JNI/C++.
auto& concreteShadowNode = dynamic_cast<${shadowNodeClassName}&>(shadowNode);
auto& concreteShadowNode = static_cast<${shadowNodeClassName}&>(shadowNode);
const ${propsClassName}& props = concreteShadowNode.getConcreteProps();
${stateClassName} state;
state.setProps(props);
Expand Down
2 changes: 1 addition & 1 deletion packages/nitrogen/src/views/kotlin/KotlinHybridViewManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ void J${stateUpdaterName}::updateViewProps(jni::alias_ref<jni::JClass> /* class
static_cast<react::StateWrapperImpl::javaobject>(rawStateWrapper)};
std::shared_ptr<const react::State> state = stateWrapper->cthis()->getState();
auto concreteState = std::dynamic_pointer_cast<const ConcreteStateData>(state);
auto concreteState = std::static_pointer_cast<const ConcreteStateData>(state);
const ${stateClassName}& data = concreteState->getData();
const std::optional<${propsClassName}>& maybeProps = data.getProps();
if (!maybeProps.has_value()) {
Expand Down
2 changes: 1 addition & 1 deletion ...nitro-test/nitrogen/generated/android/c++/views/JHybridRecyclableTestViewStateUpdater.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ void JHybridRecyclableTestViewStateUpdater::updateViewProps(jni::alias_ref<jni::
static_cast<react::StateWrapperImpl::javaobject>(rawStateWrapper)};

std::shared_ptr<const react::State> state = stateWrapper->cthis()->getState();
auto concreteState = std::dynamic_pointer_cast<const ConcreteStateData>(state);
auto concreteState = std::static_pointer_cast<const ConcreteStateData>(state);
const HybridRecyclableTestViewState& data = concreteState->getData();
const std::optional<HybridRecyclableTestViewProps>& maybeProps = data.getProps();
if (!maybeProps.has_value()) {
Expand Down
2 changes: 1 addition & 1 deletion ...ct-native-nitro-test/nitrogen/generated/android/c++/views/JHybridTestViewStateUpdater.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ void JHybridTestViewStateUpdater::updateViewProps(jni::alias_ref<jni::JClass> /*
static_cast<react::StateWrapperImpl::javaobject>(rawStateWrapper)};

std::shared_ptr<const react::State> state = stateWrapper->cthis()->getState();
auto concreteState = std::dynamic_pointer_cast<const ConcreteStateData>(state);
auto concreteState = std::static_pointer_cast<const ConcreteStateData>(state);
const HybridTestViewState& data = concreteState->getData();
const std::optional<HybridTestViewProps>& maybeProps = data.getProps();
if (!maybeProps.has_value()) {
Expand Down
2 changes: 1 addition & 1 deletion ...tive-nitro-test/nitrogen/generated/shared/c++/views/HybridRecyclableTestViewComponent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ namespace margelo::nitro::test::views {
void HybridRecyclableTestViewComponentDescriptor::adopt(react::ShadowNode& shadowNode) const {
// This is called immediately after `ShadowNode` is created, cloned or in progress.
// On Android, we need to wrap props in our state, which gets routed through Java and later unwrapped in JNI/C++.
auto& concreteShadowNode = dynamic_cast<HybridRecyclableTestViewShadowNode&>(shadowNode);
auto& concreteShadowNode = static_cast<HybridRecyclableTestViewShadowNode&>(shadowNode);
const HybridRecyclableTestViewProps& props = concreteShadowNode.getConcreteProps();
HybridRecyclableTestViewState state;
state.setProps(props);
Expand Down
2 changes: 1 addition & 1 deletion ...s/react-native-nitro-test/nitrogen/generated/shared/c++/views/HybridTestViewComponent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ namespace margelo::nitro::test::views {
void HybridTestViewComponentDescriptor::adopt(react::ShadowNode& shadowNode) const {
// This is called immediately after `ShadowNode` is created, cloned or in progress.
// On Android, we need to wrap props in our state, which gets routed through Java and later unwrapped in JNI/C++.
auto& concreteShadowNode = dynamic_cast<HybridTestViewShadowNode&>(shadowNode);
auto& concreteShadowNode = static_cast<HybridTestViewShadowNode&>(shadowNode);
const HybridTestViewProps& props = concreteShadowNode.getConcreteProps();
HybridTestViewState state;
state.setProps(props);
Expand Down
Loading