Skip to content

Repro: Independent packages are messing references in nitrogen #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NotGeorgeMessier wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Repro: Independent packages are messing references in nitrogen #1277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d79e96
init_packages
Mar 28, 2026
f305f8e
better example
Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 10 additions & 4 deletions example/ios/NitroExample.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,10 @@
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = CJW62Q77E7;
DEVELOPMENT_TEAM = Y9326JGWX2;
ENABLE_BITCODE = NO;
INFOPLIST_FILE = NitroExample/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = "Nitro Example";
Expand All @@ -405,8 +407,9 @@
"-ObjC",
"-lc++",
);
PRODUCT_BUNDLE_IDENTIFIER = com.mrousavy.nitro.example;
PRODUCT_BUNDLE_IDENTIFIER = com.mrousavy.nitro.example.akol;
PRODUCT_NAME = NitroExample;
PROVISIONING_PROFILE_SPECIFIER = "";
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
SUPPORTS_MACCATALYST = NO;
SWIFT_OBJC_INTEROP_MODE = objc;
Expand All @@ -423,8 +426,10 @@
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = CJW62Q77E7;
DEVELOPMENT_TEAM = Y9326JGWX2;
INFOPLIST_FILE = NitroExample/Info.plist;
INFOPLIST_KEY_CFBundleDisplayName = "Nitro Example";
INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.developer-tools";
Expand All @@ -439,8 +444,9 @@
"-ObjC",
"-lc++",
);
PRODUCT_BUNDLE_IDENTIFIER = com.mrousavy.nitro.example;
PRODUCT_BUNDLE_IDENTIFIER = com.mrousavy.nitro.example.akol;
PRODUCT_NAME = NitroExample;
PROVISIONING_PROFILE_SPECIFIER = "";
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
SUPPORTS_MACCATALYST = NO;
SWIFT_OBJC_INTEROP_MODE = objc;
Expand Down
36 changes: 32 additions & 4 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,30 @@ PODS:
- ReactCommon/turbomodule/core
- ReactNativeDependencies
- Yoga
- NitroPlayer (0.7.0):
- hermes-engine
- NitroModules
- RCTRequired
- RCTTypeSafety
- React-callinvoker
- React-Core
- React-Core-prebuilt
- React-debug
- React-Fabric
- React-featureflags
- React-graphics
- React-ImageManager
- React-jsi
- React-NativeModulesApple
- React-RCTFabric
- React-renderercss
- React-rendererdebug
- React-utils
- ReactCodegen
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- ReactNativeDependencies
- Yoga
- NitroTest (0.35.2):
- hermes-engine
- NitroModules
Expand Down Expand Up @@ -1976,6 +2000,7 @@ DEPENDENCIES:
- FBLazyVector (from `../../node_modules/react-native/Libraries/FBLazyVector`)
- hermes-engine (from `../../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec`)
- NitroModules (from `../../node_modules/react-native-nitro-modules`)
- NitroPlayer (from `../../node_modules/react-native-nitro-player`)
- NitroTest (from `../../node_modules/react-native-nitro-test`)
- NitroTestExternal (from `../../node_modules/react-native-nitro-test-external`)
- RCTDeprecation (from `../../node_modules/react-native/ReactApple/Libraries/RCTFoundation/RCTDeprecation`)
Expand Down Expand Up @@ -2062,6 +2087,8 @@ EXTERNAL SOURCES:
:tag: hermes-v0.14.0
NitroModules:
:path: "../../node_modules/react-native-nitro-modules"
NitroPlayer:
:path: "../../node_modules/react-native-nitro-player"
NitroTest:
:path: "../../node_modules/react-native-nitro-test"
NitroTestExternal:
Expand Down Expand Up @@ -2217,8 +2244,9 @@ EXTERNAL SOURCES:

SPEC CHECKSUMS:
FBLazyVector: 7c1d69992204c5ec452eeefa4a24b0ff311709c8
hermes-engine: 16e781d7fca74c8bb3ca59b99527d9633ee9ee36
hermes-engine: 4df240db09b8f56297ca8e63c2a793d538964397
NitroModules: 113b4a704e0d6a436d2c5600d5af41f847b0fdd1
NitroPlayer: 274fe1f4cae54e6e013fc98f3ffe76d567c3dc63
NitroTest: 69754d44fa98075944565e5df6b321c09f2ee4be
NitroTestExternal: 63f62beac90ad88b7c04f02928859441451fb42c
RCTDeprecation: dbbb85eae640e3b43cc16462d0476b00ca5959ae
Expand All @@ -2229,7 +2257,7 @@ SPEC CHECKSUMS:
React: f6f8fc5c01e77349cdfaf49102bcb928ac31d8ed
React-callinvoker: 3e62a849bda1522c6422309c02f5dc3210bc5359
React-Core: 0b765bc7c2b83dff178c2b03ed8a0390df26f18c
React-Core-prebuilt: 88810feb58457484bff17e9e91a15453407d745a
React-Core-prebuilt: 37f17c7949e91eea47a1b8878c231d9c898f46d5
React-CoreModules: 55b932564ba696301cb683a86385be6a6f137e57
React-cxxreact: 5bfb95256fde56cc0f9ce425f38cfaa085e71ad2
React-debug: f9dda2791d3ebe2078bc6102641edab77917efb7
Expand Down Expand Up @@ -2292,9 +2320,9 @@ SPEC CHECKSUMS:
ReactAppDependencyProvider: 23e2bca1661f8781e55fcc05a151fc1df97bc1fb
ReactCodegen: c049d7e966ed24be56d8e21cb1b8880316975e76
ReactCommon: 89ccc6cb100ca5a0303b46483037ef8f3e06e2e0
ReactNativeDependencies: 1a7e3c3ffa57533d8118dd9bc01790ffa9e02a3b
ReactNativeDependencies: a482285e53605a6a6f4d3c4221906a65051d584b
RNScreens: dd61bc3a3e6f6901ad833efa411917d44827cf51
Yoga: 21f482cbc18b56cdc477cd3a0c5b8c2c83ac27ce
Yoga: 90687fcd1ebd927341caed917696d692813c0b24

PODFILE CHECKSUM: cc2ab22c5169410d8739c73db2747f1617e7eaf0

Expand Down
3 changes: 2 additions & 1 deletion example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@
"deep-equal": "^2.2.3",
"react": "19.2.0",
"react-native": "0.83.0",
"react-native-nitro-modules": "*",
"react-native-nitro-player": "^0.7.0",
"react-native-nitro-test": "*",
"react-native-nitro-test-external": "*",
"react-native-nitro-modules": "*",
"react-native-safe-area-context": "^5.6.2",
"react-native-screens": "^4.14.0"
},
Expand Down
2 changes: 2 additions & 0 deletions ...native-nitro-test-external/nitrogen/generated/android/NitroTestExternal+autolinking.cmake
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions ...s/react-native-nitro-test-external/nitrogen/generated/android/NitroTestExternalOnLoad.cpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

53 changes: 53 additions & 0 deletions packages/react-native-nitro-test-external/nitrogen/generated/android/c++/JHybridBaseSpec.cpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

63 changes: 63 additions & 0 deletions packages/react-native-nitro-test-external/nitrogen/generated/android/c++/JHybridBaseSpec.hpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

54 changes: 54 additions & 0 deletions ...ernal/nitrogen/generated/android/kotlin/com/margelo/nitro/test/external/HybridBaseSpec.kt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions ...-native-nitro-test-external/nitrogen/generated/ios/NitroTestExternal-Swift-Cxx-Bridge.cpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading