Skip to content

Conversation

@boorad
Copy link
Contributor

@boorad boorad commented Jan 25, 2025

mostly from https://github.com/liontariai/react-native-fast-tflite fork, updated for v1.5.1

fixes #87

@boorad boorad changed the title fix: add support for new architecture feat: add support for new architecture Jan 25, 2025
Copy link
Owner

@mrousavy mrousavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - just a small nitpick.

also this breaks backwards compatibility right? not a problem for me

@boorad boorad requested a review from mrousavy January 30, 2025 13:31
@liontariai
Copy link

liontariai commented Feb 4, 2025

Oh cool, thanks for taking the initiative @boorad !, I just can't find the time even though I'm following the thread I'm getting mentioned in 🙈

What I'm not sure about is the android side of things... I didn't look into that.

@mrousavy mrousavy merged commit 7eb20be into mrousavy:main Feb 17, 2025
6 checks passed
@mrousavy
Copy link
Owner

perfect LGTM! thanks

@justrustc
Copy link

When will the new version be released?

@mrousavy
Copy link
Owner

Released in 1.6.0! :)

@DragonDare
Copy link

does this not work with RN 0.76 and 0.77? Build is erroring out for me with v1.6.0

@pawan-live
Copy link

does this not work with RN 0.76 and 0.77? Build is erroring out for me with v1.6.0

If you're getting an error saying the spec folder is missing, then you can add it from the repo and patch the package for now, until the next release 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS]: "RNTfliteSpec.h" not found in RN 0.75 with new arch

6 participants