Skip to content

Conversation

ngocle2497
Copy link
Contributor

In the PR, it drop support RN <0.71.
In this PR, i remove package from AndroidManifest.xml file when ANDROID_GRADLE_PLUGIN_VERSION >=7

@mrousavy
Copy link
Owner

mrousavy commented Jul 3, 2023

Is there any harm in just adding namespace no matter if we're on RN 0.70 or RN 0.73? Why do we need to check that?

@fobos531
Copy link
Contributor

Is there any harm in just adding namespace no matter if we're on RN 0.70 or RN 0.73? Why do we need to check that?

Nope, that should do the trick @mrousavy . In fact, even Nicola suggested this as a viable approach. See: react-native-community/discussions-and-proposals#671 (comment)

@mrousavy
Copy link
Owner

Great - @MasonLe2497 can you update your PR to revert all changes in build.gradle and just have the updated AndroidManifest here? Thanks!

@ngocle2497 ngocle2497 closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants