Add local time zone & time formatting configuration#9
Open
friedbunny wants to merge 4 commits intomrrama:masterfrom
friedbunny:local-timezone
Open
Add local time zone & time formatting configuration#9friedbunny wants to merge 4 commits intomrrama:masterfrom friedbunny:local-timezone
friedbunny wants to merge 4 commits intomrrama:masterfrom
friedbunny:local-timezone
Conversation
Use moment.js to add option to display timestamps in local time, but default to UTC. Also add the option to customize the time formatting, using [moment.js conventions](http://momentjs.com/docs/#/displaying/format/). Add `config.UTC: TRUE`, `config.timeFormat: moment.defaultFormat`
Author
|
Just a note: rudely, my PR does break the tests and changes the default time format to Old format would be This seems like a moment.js bug, actually... I couldn't get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use moment.js to add option to display timestamps in local time, but default to UTC. Also add the option to customize the time formatting, using moment.js conventions.
Adds moment.js dependency.
Adds options:
config.UTC: TRUEconfig.timeFormat: moment.defaultFormat