Open
Conversation
Changed the way `sum` was computed in `getImagesTotal()` to avoid black screen with "no (new) images could be found" in the warning log.
Fix Fill and Do Nothing image handling.
Addresses mrworf#186
and bugfix on shell mime checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to backup and restore settings on the current master branch.
I'm not sure why it includes the commits from 2021, but they were fixes for network timeout, for getting confused on the number of pictures on a USB, and for doing the wrong thing for the "do nothing" resizing option.
Not sure how you typically test for production, but I've been running this code for half a day on a single frame running a monitor at HD resolution, and with no sensor or buttons. (All my sensors are unsupported in this release). I've repeatedly backed up and restored two different configurations (so I can see a difference).