Skip to content

Add warnings for depth exceeded, add infinite recursion detection and warning #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msftrncs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add warnings for depth exceeded, add infinite recursion detection and warning #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions ConvertTo-CSON.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function ConvertTo-Cson {
[AllowEmptyCollection()]
[AllowEmptyString()]
[AllowNull()]
[object] $InputObject,
[Object] $InputObject,

[PSDefaultValue(Help = 'Tab')]
[string] $Indent = "`t",
Expand Down Expand Up @@ -89,7 +89,7 @@ function ConvertTo-Cson {
$name
}
):$(
if (($level -gt $Depth) -or ($null -eq $value) -or ($value -is [valuetype]) -or ($value -is [string])) {
if (($null -eq $value) -or ($value -is [valuetype]) -or ($value -is [string]) -or (WarnDepthExceeded ($level -gt $Depth))) {
" $(, $value | writeValue)" # comma forces $value to be treated as a whole object instead of being enumerated as subitems
}
elseif ($value -is [Collections.IList]) {
Expand Down Expand Up @@ -164,7 +164,27 @@ function ConvertTo-Cson {
}
}

if (($level -gt $Depth) -or ($null -eq $item) -or ($item -is [valuetype]) -or ($item -is [string])) {
function WarnInfRecursion ([bool] $InfRecursionDetected) {
if ($InfRecursionDetected) {
if (-not $script:InfRecursionDetected) {
$script:InfRecursionDetected = $true
Write-Warning 'Resulting CSON is truncated as serialization would result in infinite recursion.'
}
}
return $InfRecursionDetected
}

function WarnDepthExceeded ([bool] $DepthExceeded) {
if ($DepthExceeded) {
if (-not $script:DepthExceeded) {
$script:DepthExceeded = $true
Write-Warning "Resulting CSON is truncated as serialization has exceeded the set depth of $Depth."
}
}
return $DepthExceeded
}

if (($null -eq $item) -or ($item -is [valuetype]) -or ($item -is [string]) -or (WarnDepthExceeded ($level -gt $Depth)) -or (WarnInfRecursion (-not $recurseTree.Add($item)))) {
"$indention$(, $item | writeValue)" # comma forces $item to be treated as a whole object instead of being enumerated as subitems
} else {
$level++ # level increases for arrays or objects
Expand Down Expand Up @@ -194,12 +214,16 @@ function ConvertTo-Cson {
} else {
"$indention{}" # indicate empty object
}
$null = $recurseTree.Remove($item)
}
}

# start writing the input object starting with no indent at level 0
[string] $indention = ''
[int32] $level = 0
$recurseTree = [Collections.Generic.HashSet[Object]]::new();
[bool] $script:InfRecursionDetected = $false
[bool] $script:DepthExceeded = $false
(writeObject $(
# we need to determine where our input is coming from, pipeline or parameter argument.
if ($input -is [array] -and $input.Length -ne 0) {
Expand Down