Skip to content

Fix obs.mat feature of fitcn#71

Open
ShaiberAlon wants to merge 4 commits intomasterfrom
as.dev
Open

Fix obs.mat feature of fitcn#71
ShaiberAlon wants to merge 4 commits intomasterfrom
as.dev

Conversation

@ShaiberAlon
Copy link
Collaborator

@ShaiberAlon ShaiberAlon commented Dec 13, 2021

  1. Had to change cbind/rbind -> cbind2/rbind2
  2. trim the solution after optimization to remove the rows that were added due to obs.mat
  3. unrelated to fitcn: added `%+%` = gUtils::`%+%` to apps.R because otherwise sometimes (depending on library include order) the ggplot %+% is used instead of the gUtils.
  4. only setting 'grl.labelfield'to "name" if it was not supplied already as a metadata field

cbind2

I honestly don't understand why cbind doesn't work, but it doens't. cbind is supposed to recursively call cbind2, but it doesn't seem to do so. This is quite annoying because cbind2 only works on two matrixes so we need to explicitly call it recursively each time on a pair of matrixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant