Skip to content

dts: msm8909: Add support for Andromax A (A16C3H) #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HaHmada wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dts: msm8909: Add support for Andromax A (A16C3H) #585

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88596c2
dts: msm8909: Add support for Andromax A (A16C3H)
HaHmada Sep 19, 2025
a950f59
dts: msm8909: Add support for Andromax A (A16C3H)
HaHmada Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions lk2nd/device/dts/msm8909/msm8909-andromax-a16c3h.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// SPDX-License-Identifier: GPL-2.0-only

#include <skeleton64.dtsi>
#include <lk2nd.dtsi>

/ {
// This is used by the bootloader to find the correct DTB
qcom,msm-id = <206 0>;
Copy link
Contributor

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
qcom,msm-id = <206 0>;
qcom,msm-id = <QCOM_ID_MSM8909 0>;

206? msm8916?

https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/include/dt-bindings/arm/qcom%2Cids.h#L75

Copy link
Author

@HaHmada HaHmada Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh Sorry, I'm New Here So Just Forgive Me If I'm Wrong :)

qcom,board-id = <0x1000b 0x8>, <0x11000b 0x8>, <0x21000b 0x8>;
Copy link
Contributor

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/device/dts/msm8909/msm8909-1gb-qrd-skuc.dts#L7-L10

This device could be one of skuc device, so let's move the device to skuc.

Copy link
Author

@HaHmada HaHmada Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owh, Okay

};

&lk2nd {
model = "Andromax A"; // FIXME
compatible = "andromax,a16c3h"; // FIXME

lk2nd,dtb-files = "msm8916-andromax-a16c3h";
Copy link
Contributor

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lk2nd,dtb-files = "msm8916-andromax-a16c3h";
lk2nd,dtb-files = "msm8916-andromax-a16c3h";

Use tabs.

Copy link
Author

@HaHmada HaHmada Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I Accidentally Press Backspace Before :)


};