Skip to content

Conversation

@fardin-developer
Copy link
Contributor

@fardin-developer fardin-developer commented Jan 17, 2025

Fixes #14
This pull request adds Docker support to the project. The following changes were made:

  • Created a Dockerfile to containerize the application.
  • Added necessary dependency like agentic_security in requirements.txt.
  • The application can now be built and run inside a Docker container.

To build and run the Docker container:

  1. Build the image: docker build -t agentic-security .
  2. Run the container: docker run -p 8718:8718 agentic-security

@msoedov
Copy link
Owner

msoedov commented Jan 17, 2025

@fardin-developer, thanks for the PR! Let me review it and get back to you shortly.

@fardin-developer
Copy link
Contributor Author

@msoedov Great, looking forward to your feedback.

Dockerfile Outdated
EXPOSE 8718

# Run the initialization command first, then start the application
# CMD ["sh", "-c", "python -m agentic_security i && python -m agentic_security s"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure I just kept there if some one want to run the project with docker then they can do that easily

@msoedov
Copy link
Owner

msoedov commented Jan 17, 2025

LGTM except those 2 minor comments, thx for the patch!

@msoedov msoedov merged commit fc21339 into msoedov:main Jan 19, 2025
3 checks passed
@msoedov
Copy link
Owner

msoedov commented Jan 19, 2025

@fardin-developer thank you! merged

@fardin-developer
Copy link
Contributor Author

Hey @msoedov
I came across your GitHub profile and I really admire your work! I'm a junior developer eager to learn and grow and I’d love the opportunity to work with you in any capacity. If you have any projects where I can contribute, I'd be happy to help. Let me know if there's a way I can get involved! If my work impresses you, we can discuss compensation later. I just want to work with a senior engineer like you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Dockerfile

2 participants