Skip to content

Conversation

@v-federicoar
Copy link
Contributor

  • Net10
  • Api version
  • Fix test
  • Some typos

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request attempts to upgrade the codebase from .NET 9.0 to .NET 10.0, update Azure resource API versions to 2025 versions, fix a test assertion, and correct several typos in documentation. However, the PR contains critical issues that prevent it from being merged.

Key changes:

  • Upgrade all .NET projects and Docker images from version 9.0 to 10.0
  • Update Azure API versions across Bicep files to 2025 versions
  • Fix async test assertion in GlobalLoggerMiddlewareFixture
  • Correct spelling and documentation typos

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
workload/workload-stamp.bicep Updates Azure API versions for Redis, CosmosDB resources to 2025 versions
workload/nested_workload-stamp.bicep Updates Container Registry API version to 2025-11-01
main.bicep Updates Container Apps resiliency policy API versions and corrects SAS key description typos
environment.bicep Updates Log Analytics and Container Apps Environment API versions; contains typo in description
container-http.bicep Updates Container Registry and Container Apps API versions; improves parameter descriptions
acrpull-roleassignment.bicep Updates Container Registry API version and improves parameter descriptions
Fabrikam.Workflow.Service.csproj Upgrades target framework to net10.0 and updates package versions
Fabrikam.Workflow.Service.Tests.csproj Upgrades target framework to net10.0 and updates test package versions
Fabrikam.DroneDelivery.DroneSchedulerService.csproj Upgrades target framework to net10.0 and updates package versions
Fabrikam.DroneDelivery.DroneSchedulerService.Tests.csproj Upgrades target framework to net10.0 and updates test package versions
Fabrikam.DroneDelivery.DroneSchedulerService/Startup.cs Changes using statement from Microsoft.OpenApi.Models to Microsoft.OpenApi (breaking change)
Fabrikam.DroneDelivery.DeliveryService.csproj Upgrades target framework to net10.0, enables ImplicitUsings, and updates packages
Fabrikam.DroneDelivery.DeliveryService/Startup.cs Changes using statement from Microsoft.OpenApi.Models to Microsoft.OpenApi (breaking change)
Fabrikam.DroneDelivery.DeliveryService.Tests.csproj Upgrades target framework to net10.0 with inconsistent package version updates
Fabrikam.DroneDelivery.DeliveryService.Tests/GlobalLoggerMiddlewareFixture.cs Fixes test assertion from synchronous Throws to asynchronous ThrowsAsync
Fabrikam.DroneDelivery.Common.csproj Upgrades target framework to net10.0 and enables ImplicitUsings
workflow/Dockerfile Updates base and SDK images to .NET 10.0
dronescheduler/Dockerfile Updates base and SDK images to .NET 10.0
delivery/Dockerfile Updates base and SDK images to .NET 10.0
workload/src/loadtest/readme.md Corrects multiple spelling errors (narrative, excerpts, exercise, metrics, inefficient, Throughout→Throughput, Overall)
README.md Updates resource group naming and improves Container Apps Environment capitalization
Comments suppressed due to low confidence (1)

workload/src/shipping/delivery/Fabrikam.DroneDelivery.DeliveryService.Tests/GlobalLoggerMiddlewareFixture.cs:237

  • This assignment to ex is useless, since its value is never read.
            var ex = await Assert.ThrowsAsync<Exception>(async () => {
                // Act
                try
                {
                    await logRequestMiddleware.Invoke(contextMock.Object);
                }
                // Assert
                catch (Exception)
                {
                    loggerMock.Verify(l => l.Log(
                                            LogLevel.Error,
                                            It.IsAny<EventId>(),
                                            It.Is<It.IsAnyType>((object fV, Type _) => fV.ToString().Equals(($"An exception was thrown attempting to execute the global internal server error handler: {exMessage}"))),
                                            It.IsAny<Exception>(),
                                            (Func<It.IsAnyType, Exception, string>)It.IsAny<object>()));

                    loggerMock.Verify(l => l.Log(
                            LogLevel.Warning,
                            It.IsAny<EventId>(),
                            It.Is<It.IsAnyType>((object fV, Type _) => fV.ToString().Equals(("The response has already started, the error handler will not be executed."))),
                            null,
                            (Func<It.IsAnyType, Exception, string>)It.IsAny<object>()));
                    // re-throw the actual re-throw 
                    throw;
                }
            });

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@skabou skabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed successfully. 🚀

@skabou skabou merged commit 76cf8c9 into mspnp:main Jan 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants