Skip to content

Commit 7e0dbe7

Browse files
committed
Stop building libcxx with LIBCXX_ABI_UNSTABLE=TRUE
This didn't seem to actually be necessary, not even in the initial commit adding support for building a DLL of libcxx. It might have been necessary at some earlier point while working on building a DLL.
1 parent 7a86e4c commit 7e0dbe7

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,6 @@ normal GCC/binutils based MinGW.
7171

7272
- The windres replacement, llvm-rc, isn't very mature and doesn't support
7373
everything that GNU windres does.
74-
- The DLL version of libc++ doesn't have a fixed supported ABI, so in theory,
75-
code built against an older version of the DLL is not guaranteed to work
76-
with a newer version of the DLL.
7774
- The toolchain defaults to using the Universal CRT (which is only available
7875
out of the box since Windows 10, but can be installed on Vista or newer)
7976
and defaults to targeting Vista. These defaults can be changed in

build-libcxx.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ build_all() {
167167
-DLIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS=OFF \
168168
-DLLVM_NO_OLD_LIBSTDCXX=TRUE \
169169
-DCXX_SUPPORTS_CXX11=TRUE \
170-
-DCMAKE_CXX_FLAGS="$LIBCXXABI_VISIBILITY_FLAGS -D_LIBCPP_HAS_THREAD_API_WIN32 -D_LIBCPP_ABI_UNSTABLE -w" \
170+
-DCMAKE_CXX_FLAGS="$LIBCXXABI_VISIBILITY_FLAGS -D_LIBCPP_HAS_THREAD_API_WIN32 -w" \
171171
..
172172
make -j$CORES
173173
cd ..
@@ -208,7 +208,6 @@ build_all() {
208208
-DLIBCXX_ENABLE_EXPERIMENTAL_LIBRARY=OFF \
209209
-DLIBCXX_ENABLE_FILESYSTEM=OFF \
210210
-DLIBCXX_ENABLE_STATIC_ABI_LIBRARY=TRUE \
211-
-DLIBCXX_ABI_UNSTABLE=TRUE \
212211
-DLIBCXX_CXX_ABI=libcxxabi \
213212
-DLIBCXX_CXX_ABI_INCLUDE_PATHS=../../libcxxabi/include \
214213
-DLIBCXX_CXX_ABI_LIBRARY_PATH=../../libcxxabi/build-$arch-$type/lib \

0 commit comments

Comments
 (0)