feat: support RequestController with source
#749
Merged
+530
−382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
BREAKING CHANGE: We now handle mock response stream errors the same way Node.js handles them: write response headers as-is (e.g. 200 OK), then emit "error" on the response and abort the request without request errors. Previously, we coerced mock response stream errors to 500, which was wild magic and we shouldn't have done that.
setupRemoteServermsw#1617Changes
Make the
RequestControllerclass accept a source object that implements the request handling methods (passthrough/respondWith/errorWith). We might eventually use this instead of the network frames in MSW as they are, effectively, the same thing.Follow-ups
RequestControllermethods asynchronous to have a consistent function flow.Todos
nocktests are passing with this change.mswtests are passing with this change.