Conversation
|
@kettanaito I can help with this, if you want? |
|
@Stanzilla, absolutely! Any help would be appreciated, especially if we can keep the changes to the minimum here. |
|
Hey! I noticed a couple of typos in
Also worth double-checking: in |
|
Thanks, @Stanzilla, good finds! Meanwhile, I solve the e2e tests so the builds are passing. |
Failing Nock testsA single test is failing, which is related to Node.js v24, somehow. On v24, the same scenario on our end is failing also, likely related to #762 (breaking changes in Node.js). Weird, since our It's worth mentioning that the actual failure reason on the CI is obscure, highly suggesting that the Nock repo can no longer be run on Node.js v20. But not what's claimed in engines. Update: the mistake is on our end, it just doesn't surface nicely: const {
default: nodeInterceptors,
} = require('@mswjs/interceptors/presets/node')
const SEPARATOR = '\n<<<<<<-- cut here -->>>>>>\n'
let recordingInProgress = false
let outputs = []
// TODO: don't reuse the nodeInterceptors, create new ones.
const clientRequestInterceptor = nodeInterceptors[0]Here, Update: Nope, we export things correctly. What a wild ride. The issue was that only one export condition of Root cause
SolutionEnsured consistent |
|
|
Opened a pull request to Nock to see if dropping that require alias would not be an issue: nock/nock#2938. |
|
I've confirmed that the Nock changes are valid against this version of Interceptors and their entire test suite is passing. This has to be released with a broken Nock compatibility until I bump the Interceptors version in Nock. |
tsdown for bundlingtsdown for bundling
Released: v0.41.0 🎉This has been released in v0.41.0. Get these changes by running the following command: Predictable release automation by Release. |
tsdownfor bundling.exports, including at the nested paths, like/presets.aliasfrom tsdown config as it resolves aliases fromtsconfiginstead.tsconfig.browser.jsonto resolve theinternal:brotli-compresscorrectly during the build.typesfrom export extensions to rely on implicit dts lookup.Motivation
ossjs/release.ossjs/releaseusespublintfor package linting.