Merged
Conversation
kettanaito
reviewed
Aug 30, 2025
src/open-api/from-open-api.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| import { HttpHandler, http } from 'msw' | |||
| import type { OpenAPIV3, OpenAPIV2, OpenAPI } from 'openapi-types' | |||
| import type { OpenAPIV3_1, OpenAPIV3, OpenAPIV2, OpenAPI } from 'openapi-types' | |||
Member
There was a problem hiding this comment.
Are V3_1 types different from V3? 🤔 They probably introduce new features, right?
kettanaito
reviewed
Aug 30, 2025
src/open-api/from-open-api.ts
Outdated
| */ | ||
| export async function fromOpenApi( | ||
| document: string | OpenAPI.Document | OpenAPIV3.Document | OpenAPIV2.Document, | ||
| document: |
Member
There was a problem hiding this comment.
It would be great to add some tests to make sure we actually support OAS 3.1. You don't have to add them yourself but I'd appreciate if you shared some usage examples that rely on 3.1 and then we can put them into automated tests.
kettanaito
reviewed
Sep 16, 2025
src/open-api/from-open-api.ts
Outdated
| document: | ||
| | string | ||
| | OpenAPI.Document | ||
| | OpenAPIV3_1.Document |
Member
There was a problem hiding this comment.
There's no need to add explicit V3_1 and V3 reference as they are included in the OpenAPI namespace automatically:
export declare namespace OpenAPI {
type Document<T extends {} = {}> = OpenAPIV2.Document<T> | OpenAPIV3.Document<T> | OpenAPIV3_1.Document<T>;
kettanaito
force-pushed
the
feat/oapi3.1-support
branch
from
a610642 to
083f8cc
Compare
Member
Released: v0.5.0 🎉This has been released in v0.5.0! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71