Skip to content

Fixed parameter "_" preset for limit and offset parameters for portals #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyk merged 1 commit into from
Sep 11, 2025
Merged

Fixed parameter "_" preset for limit and offset parameters for portals #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Supporting/FileMakerLayout.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
string $method = "GET"): array
{
$key = $shortKey ? "portal" : "portalData";
$prefix = $method === "GET" ? "" : "_";
$prefix = $method === "GET" ? "_" : "";
$request = [];
if (array_values($param) === $param) {
$request[$key] = $param;
Expand Down Expand Up @@ -268,7 +268,7 @@
$dataInfo = clone $result->response->dataInfo;
$dataInfo->returnedCount = 1;
}
$fmrel = new FileMakerRelation($result->response->data, $dataInfo,

Check failure on line 271 in src/Supporting/FileMakerLayout.php

View workflow job for this annotation

GitHub Actions / Run Phan 

PhanTypeMismatchArgumentNullable Argument 2 ($infoData) is $dataInfo of type ?object but \INTERMediator\FileMakerServer\RESTAPI\Supporting\FileMakerRelation::__construct() takes array|object defined at src/Supporting/FileMakerRelation.php:72 (expected type to be non-nullable)
"OK", $result->messages[0]->code, null, $this->restAPI);
}
$this->restAPI->logout();
Expand Down
Loading