Skip to content

Conversation

@naveen521kk
Copy link
Member

Currently, the platform names are hardcoded in many places and are not named consistently. This commit fixes it by standardizing the names to be returned by sysconfig.get_platform. The naming is based on #167 (comment)

Similarly, EXT_SUFFIX is also standardized to be consistent with the platform names.

Currently, the platform names are hardcoded in many places,
and are not named consistently. This commit fixes it by
standardizing the names to be returned by `sysconfig.get_platform`.
The naming is based on msys2-contrib#167 (comment)

Similarly, `EXT_SUFFIX` is also standardized to be consistent with the platform names.

Signed-off-by: Naveen M K <[email protected]>
@naveen521kk naveen521kk marked this pull request as draft September 12, 2024 12:16
@naveen521kk naveen521kk requested a review from lazka September 12, 2024 12:16
@naveen521kk naveen521kk marked this pull request as ready for review November 1, 2024 06:41
Copy link
Member

@lazka lazka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@naveen521kk naveen521kk merged commit b00d375 into msys2-contrib:mingw-v3.12.5 Nov 2, 2024
7 of 12 checks passed
@naveen521kk naveen521kk deleted the new-ext-suffix branch November 2, 2024 05:35
@naveen521kk naveen521kk mentioned this pull request Nov 2, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants