pathname2url: normalize forward slashes to backslashes before processing #183
Conversation
Fix pathname2url to handle paths with forward slashes correctly by normalizing
all forward slashes to backslashes at the start of processing. This prevents
issues where paths containing forward slashes would result in malformed URLs
with double slashes after the drive letter (e.g. "C://Users" instead of "C:/Users").
Before:
>>> pathname2url("C:/Users/example")
'//C://Users/example'
After:
>>> pathname2url("C:/Users/example")
'//C:/Users/example'
The function now handles both forward and backward slashes consistently.
|
is test_urllib buggy in purpose? why 3 forward slashes, that doesn't work |
|
How is this related to the mingw port? Is it a regression we introduced? |
jupyterlab on normal windows seem to open the browser but on mingw it doesn't |
|
Using the official CPython build: Not saying that there isn't a problem, but I doubt this is the root cause. |
|
I think it has to do something with our conversion system from that's why I think things work with the official Python but not with ours. Trying out I think this should be fixed upstream. |
|
This has been fixed |
3 participants
fixes #182
Fix pathname2url to handle paths with forward slashes correctly by normalizing all forward slashes to backslashes at the start of processing. This prevents issues where paths containing forward slashes would result in malformed URLs with double slashes after the drive letter (e.g. "C://Users" instead of "C:/Users").
Before:
After:
The function now handles both forward and backward slashes consistently.