Skip to content

Conversation

@kmilos
Copy link
Contributor

@kmilos kmilos commented Aug 25, 2025

OTOH, it might make more sense to patch libraw/libraw_types.h instead of forcing clients to define LIBRAW_WIN32_DLLDEFS as well...

Thoughts?

@kmilos kmilos marked this pull request as draft August 25, 2025 14:42
@lazka
Copy link
Member

lazka commented Aug 25, 2025

yeah, you could patch it here (_WIN32 instead of _MSC_VER): https://github.com/LibRaw/LibRaw/blob/ae32c08bfe2374c651176ecf32e07a3751697488/libraw/libraw.h#L54 and add "Cflags.private: -DLIBRAW_NODLL" to the .pc file

@lazka
Copy link
Member

lazka commented Aug 25, 2025

LIBRAW_WIN32_UNICODEPATHS also seems like it could be patched

@kmilos
Copy link
Contributor Author

kmilos commented Aug 25, 2025

I might wait for the next soversion bump to do the rebuilds anyway...

@kmilos
Copy link
Contributor Author

kmilos commented Aug 26, 2025

LIBRAW_WIN32_UNICODEPATHS also seems like it could be patched

I think that one works out correctly, I remember asking to add the _LIBCPP_HAS_OPEN_WITH_WCHAR path upstream so both GCC and LLVM are covered...

@kmilos kmilos changed the title libraw: make symbol visibility explicit libraw: update to 0.22.0 Jan 14, 2026
@kmilos kmilos marked this pull request as ready for review January 14, 2026 09:19
@kmilos
Copy link
Contributor Author

kmilos commented Jan 14, 2026

imagemagick needs a patch a la Arch. Reported upstream.

@lazka lazka merged commit 098ed34 into msys2:master Jan 15, 2026
8 checks passed
@kmilos kmilos deleted the patch-2 branch January 15, 2026 20:18
lren pushed a commit to lren/MINGW-packages that referenced this pull request Jan 20, 2026
* libraw: update to 0.22.0

* libraw rebuilds

* imagemagick: patch for libraw 0.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants