Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Commit 38b2e5d

Browse files
devzero2000gitster
authored andcommitted
t4010-diff-pathspec.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <[email protected]> Reviewed-by: Matthieu Moy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent e1d6b55 commit 38b2e5d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

t/t4010-diff-pathspec.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ test_expect_success \
1818
mkdir path1 &&
1919
echo rezrov >path1/file1 &&
2020
git update-index --add file0 path1/file1 &&
21-
tree=`git write-tree` &&
21+
tree=$(git write-tree) &&
2222
echo "$tree" &&
2323
echo nitfol >file0 &&
2424
echo yomin >path1/file1 &&
@@ -131,7 +131,7 @@ test_expect_success 'diff multiple wildcard pathspecs' '
131131
mkdir path2 &&
132132
echo rezrov >path2/file1 &&
133133
git update-index --add path2/file1 &&
134-
tree3=`git write-tree` &&
134+
tree3=$(git write-tree) &&
135135
git diff --name-only $tree $tree3 -- "path2*1" "path1*1" >actual &&
136136
cat <<-\EOF >expect &&
137137
path1/file1

0 commit comments

Comments
 (0)