Adjust noclip hurt detection (take both feet & head node into account) #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwissalpS
reviewed
Oct 29, 2025
Comment on lines
+21
to
+25
| if is_solid_node(pos) then | ||
| pos.y = pos.y + 1 -- Player's head | ||
| if is_solid_node(pos) | ||
| and player:get_hp() > 0 | ||
| and not core.check_player_privs(player:get_player_name(), { noclip = true }) then |
Contributor
There was a problem hiding this comment.
Possible micro-optimization: if the priv check goes first, sometimes the other checks could be skipped.
I'm not sure that is worth it as noclip players are rather rare.
Maybe checking hp first can skip checking dead players' nodes over and over for nothing.
SwissalpS
approved these changes
Oct 29, 2025
Contributor
SwissalpS
left a comment
SwissalpS
left a comment
There was a problem hiding this comment.
looks better, thanks. I approve with or without my nit-pick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47