Add an optional dependency on DevTest's mapgen mod #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
unless someone makes another mod named mapgen, and its circularlly depends on pipeworks, shouldnt be an issue. additionally cdb has right to a name which should prevent (on cdb) another mod from having the name unless its compatible |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #173
By depending on mapgen, we make sure that Pipeworks loads after the required aliases are defined.
The name feels pretty common though and i don't know how to make sure that the considered mapgen mod is from DevTest. I found no mod named “mapgen” on ContentDB, so one may pop one day. Or is there something preventing it?