Skip to content

adjust mcl_dye[s] mod name based on which mcl_dye[s] mod is detected#51

Merged
wsor4035 merged 4 commits intomt-mods:masterfrom
programmerjake:fix-mcl-dyes
Mar 23, 2025
Merged

adjust mcl_dye[s] mod name based on which mcl_dye[s] mod is detected#51
wsor4035 merged 4 commits intomt-mods:masterfrom
programmerjake:fix-mcl-dyes

Conversation

@programmerjake
Copy link
Contributor

@programmerjake programmerjake commented Mar 15, 2025

Fixes: #50

I did test this manually on mineclonia and voxelibre by trying out the travelnet recipes

@programmerjake

This comment was marked as resolved.

@programmerjake

This comment was marked as resolved.

@programmerjake
Copy link
Contributor Author

fixed ci

@BuckarooBanzay
Copy link
Member

PR look good (except that i would have used a prefix variable instead of the mcl_dyes and "mcl_dyes:dark_grey" or "mcl_dye:dark_grey" thing but i don't really care)

fatal: unable to access 'https://git.minetest.land/VoxeLibre/VoxeLibre/': The requested URL returned error: 403

😒 this one is on me, sorry for the trouble

What happened with the pipeworks nodes? i thought that had worked before?

@programmerjake
Copy link
Contributor Author

What happened with the pipeworks nodes? i thought that had worked before?

mineclonia renamed their mesecons mod to mcl_redstone so when pipeworks uses minetest.get_modpath("mesecons") it fails. they did add all the mesecons:* items as aliases though. I described that in the commit message 6d23629

@BuckarooBanzay BuckarooBanzay requested a review from wsor4035 March 20, 2025 11:55
Copy link
Contributor

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@programmerjake
Copy link
Contributor Author

removed the commit changing the git url, also redid the ... and ... or ... stuff while I was at it

Copy link
Contributor

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wsor4035 wsor4035 merged commit c87b4b9 into mt-mods:master Mar 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mineclonia and voxelibre disagree on mcl_dye[s] mod name

3 participants