Don't allow auto pump and break when Unsmiling Tsarevna rez ability triggered#7936
Merged
NoahTheDuke merged 1 commit intomtgred:masterfrom Feb 22, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6844
Couldn't really work out a better way to do this.
I looked at Afshar and Ahket and both those use
:breakablefunctions on their subroutines and then return:unrestrictedwhen the qualifying static condition is not true - but when the condition is true then the auto-break code doesn't actually care if the `:breakable: function returns true or false and decides the ice can't be auto-broken.I'm not sure how I'd replace the current
:cannot-break-subs-on-icelingering effect with a similar:breakablefunctions on subs that checks if the Corp has given the Runner 2 credits.So instead just opted for an additional lingering "effect" which the auto-break code guards against.