prevent frontend lockup when bad things happen on the server#7941
Merged
NoahTheDuke merged 1 commit intomtgred:masterfrom Feb 22, 2025
Merged
prevent frontend lockup when bad things happen on the server#7941NoahTheDuke merged 1 commit intomtgred:masterfrom
NoahTheDuke merged 1 commit intomtgred:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the
try/catchhad to go inside the thread. Whoops.This should get us our error stacktraces back, and error logs on the frontend (for the last few months, if there was an error, the front-end would appear to lock up because it never got a response that you were allowed to act again).
Closes #7862