Skip to content

NCIGS changes#7983

Closed
NBKelly wants to merge 17 commits intomtgred:masterfrom
NBKelly:ncigs-changes
Closed

NCIGS changes#7983
NBKelly wants to merge 17 commits intomtgred:masterfrom
NBKelly:ncigs-changes

Conversation

@NBKelly
Copy link
Collaborator

@NBKelly NBKelly commented Mar 2, 2025

I made it so that instead of passing a fn in like:

{:effect ...
 :no-change-in-game-state (req ...)}

we instead pass in a map like

{:effect ...
 :no-change-in-game-state {:req (req ...)
                           :silent [truthy|nil]}}

I updated every ncigs reference in our code for this.

I'm going to go through and do ncigs changes on the other cards over the coming weeks.

Essentially the breakdown is as follows:

  • You are allowed to play abilities that do nothing for the sole sake of burning currency
  • Abilities that refer to the ice being encountered still require the ice to be encountered
  • Ice (make subroutines feel nicer to use)
  • Operations (done prior)
  • Identities
  • Assets
  • Upgrades
  • Agendas
  • Hardware
  • Events (done prior)
  • Resources
  • Programs (note the ice encountered rule)
  • Fix unit tests where card behaviour has changed (ie simulchip)

Along the way I've been fixing a few things:

  • Data mine had a weird async issue, same for special offer
  • Border control ability did not enforce it's condition
  • The fairchildren ice wont bother you if you can't afford either option
  • Watchtower shuffles if you cancel
  • I made a few ice use our pre-defined subs instead of rewriting them
  • Mamba can only be used during a run
  • Hades Shard is automated now
  • Ampere lives in it's alphabetical spot in the identities file now instead of down by N
  • You can use SMC during signal jamming just to shuffle if you like

This has to wait for a month or two to go out, but it's "Done" for then.

@NBKelly
Copy link
Collaborator Author

NBKelly commented Apr 16, 2025

I ended up rolling this into the elevation changes

@NBKelly NBKelly closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant