Closed
Conversation
Collaborator
Author
|
I ended up rolling this into the elevation changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made it so that instead of passing a fn in like:
{:effect ... :no-change-in-game-state (req ...)}we instead pass in a map like
{:effect ... :no-change-in-game-state {:req (req ...) :silent [truthy|nil]}}I updated every ncigs reference in our code for this.
I'm going to go through and do ncigs changes on the other cards over the coming weeks.
Essentially the breakdown is as follows:
ice being encounteredstill require the ice to be encounteredAlong the way I've been fixing a few things:
This has to wait for a month or two to go out, but it's "Done" for then.