Clean-Up of MU Ability Code#8006
Merged
NoahTheDuke merged 1 commit intomtgred:masterfrom Mar 13, 2025
Merged
Conversation
…ctions, they do not handle cases also handled by mu+ anymore but they are a lot simpler now.
Contributor
Author
|
I did testing for the virus case. The caissa case is symmetric so I didn't test it separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bunch of redundancy in the
mu+,virus-mu+andcaissa-mu+functions. I added the calling convention other mu functions callmu+to its documentation and trimmed down the other functions so they only handle the cases where they are different from themu+.If a need for these cases comes up again, turning all three into wrappers around some private core might work best, forward their arguments, with the default mu type to it and they can handle all the complex logic. But for now this handles all the same cases with less code.