Remove support for HERE router #155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably the most significant change since I took over maintenance of the project, and also a breaking change that will lead to the transition to v2 of routingpy.
Routingpy does not allow the use of HERE's v8 API, only v7 (which has been deprecated for several years).
New HERE users cannot access v7 with the tokens that can currently be created (and therefore the use of HERE in routingpy is reserved for users who already have a key).
In addition, removing support for HERE will allow us to focus on maintaining open source routers (although I am not opposed to adding support for non-open source routers if there are people willing to help maintain them). But note there is a library that allows users to use the HERE v8 API: https://github.com/eifinger/here_routing.
Finally, several issues relate to HERE and would be closed if support were removed from routingpy.
Fixes #13, fixes #32, fixes #33, fixes #119.