Skip to content

feat: add IGN router#157

Merged
mthh merged 12 commits intomthh:masterfrom
LBasara:master
Jan 8, 2026
Merged

feat: add IGN router#157
mthh merged 12 commits intomthh:masterfrom
LBasara:master

Conversation

@LBasara
Copy link
Copy Markdown
Contributor

@LBasara LBasara commented Dec 16, 2025

No description provided.

@LBasara
Copy link
Copy Markdown
Contributor Author

LBasara commented Dec 16, 2025

The commit should fix #148 , adding IGN Geoservices directions and isochrones.

@mthh
Copy link
Copy Markdown
Owner

mthh commented Dec 16, 2025

Thank you! I'll start reviewing it very soon, hoping to merge it within the week if all goes well!

Copy link
Copy Markdown
Owner

@mthh mthh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, CI jobs are failing because the poetry.lock file is no longer synchronized with the pyproject.toml file.

Once you have seen my previous comment (about the need to write the poetry dependency on the one hand, and about the dependencies on responses on the other), could you push an updated version of this poetry.lock file?

Copy link
Copy Markdown
Owner

@mthh mthh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pyproject/poetry changes!
I left a few additional comments before merging.

In addition, you should add an entry in the documentation, in the docs/index.rst file (between HereMaps and MapboxOSRM).

IGN
---

.. autoclass:: routingpy.routers.IGN
   :members:

   .. automethod:: __init__

@mthh
Copy link
Copy Markdown
Owner

mthh commented Jan 5, 2026

If you're OK with that, I'll push the few changes I suggested to your branch so I can merge it within the week!

Edit: I also changed the name of the PR for better visibility.

@mthh mthh changed the title Merge with origin feat: add IGN router Jan 5, 2026
@LBasara
Copy link
Copy Markdown
Contributor Author

LBasara commented Jan 6, 2026

If you're OK with that, I'll push the few changes I suggested to your branch so I can merge it within the week!

Edit: I also changed the name of the PR for better visibility.

Sorry I didn't have much bandwidth in the previous weeks to address the changes.
I have time now if I can help, otherwise I'm perfectly fine with the changes, and if you can merge them it would be awesome.

@mthh
Copy link
Copy Markdown
Owner

mthh commented Jan 6, 2026

Sorry I didn't have much bandwidth in the previous weeks to address the changes.

No problem, you did most of the work, and the last few things I asked for were minor details!

I'll let it sit for another half-day, but overall I think I'm now OK with merging it.

@mthh mthh merged commit 6a7b392 into mthh:master Jan 8, 2026
10 of 11 checks passed
@mthh mthh mentioned this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants