Skip to content

fix: improve placeholder prompt detection #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtth merged 1 commit into from
Apr 25, 2025
Merged

fix: improve placeholder prompt detection #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ pipx install git-draft[openai]

## Next steps

* MCP bot.
* Mechanism for reporting feedback from a bot, and possibly allowing user to
interactively respond.
* Add MCP bot.
* Store configuration in `gitconfig` as `draft.*` entries. This can be used for
example to set a unique repo ID, and default bot to use per repo (or more
widely via shared `gitconfig` files).
2 changes: 1 addition & 1 deletion src/git_draft/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def main() -> None: # noqa: PLR0912 PLR0915
editable = False
prompt = edit(
text=drafter.latest_draft_prompt() or _PROMPT_PLACEHOLDER
)
).strip()
if not prompt or prompt == _PROMPT_PLACEHOLDER:
raise ValueError("Aborting: empty or placeholder prompt")
else:
Expand Down
2 changes: 1 addition & 1 deletion src/git_draft/drafter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def _draft_ref(folio_id: int, suffix: int | str) -> str:
return f"refs/drafts/{folio_id}/{suffix}"


_FOLIO_BRANCH_NAMESPACE = "drafts"
_FOLIO_BRANCH_NAMESPACE = "draft"

_FOLIO_UPSTREAM_BRANCH_SUFFIX = "+"

Expand Down