doc(play/aws-disk-bench): add AWS disk benchmark on Kube#15
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
e642fb9 to
387f10f
Compare
20baad6 to
486c289
Compare
da68227 to
40f1bea
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new guide to benchmark AWS disks on OpenShift by updating the site navigation and introducing a detailed playbook.
- Registers “Benchmark AWS disks on OCP” in the MkDocs navigation.
- Adds
ocp-aws-disk-benchmark.mdwith steps to create MachineConfigs/MachineSets and run FIO tests. - Covers benchmarking for ephemeral, gp2, gp3, io1, and io2 disk types.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mkdocs.yml | Added nav entry for the AWS disk benchmark guide |
| docs/playbooks/openshift/ocp-aws-disk-benchmark.md | New playbook with setup and FIO benchmarking workflow |
Comments suppressed due to low confidence (2)
docs/playbooks/openshift/ocp-aws-disk-benchmark.md:1
- The title only mentions ephemeral disks but the guide covers gp2, gp3, io1, and io2 as well. Consider updating it to reflect all tested disk types, e.g., "OCP on AWS - Benchmarking Ephemeral and EBS Disk Types".
# OCP on AWS - Using Instance Disks for Ephemeral Storage
docs/playbooks/openshift/ocp-aws-disk-benchmark.md:212
- This sets
m6id.xlargefor the ephemeral test, but earlier you recommendedc6id.xlargeas an example. Ensure the instance type is intentional or align with the documented example.
export INSTANCE_TYPE="m6id.xlarge"
Comment on lines
+273
to
+279
| oc get node -l disk_type=ephemeral -w | ||
| ``` | ||
|
|
||
| Make sure the device has been mounted correctly to the mount path `/var/lib/containers`: | ||
|
|
||
| ```bash | ||
| oc debug node/$(oc get nodes -l disk_type=${disk_type} -o jsonpath='{.items[0].metadata.name}') -- chroot /host /bin/bash -c "df -h /var/lib/containers" |
There was a problem hiding this comment.
[nitpick] You mix DISK_TYPE (uppercase) and disk_type (lowercase) environment variables. It’s clearer to use one consistent naming convention for the label and variable throughout.
Suggested change
| oc get node -l disk_type=ephemeral -w | |
| ``` | |
| Make sure the device has been mounted correctly to the mount path `/var/lib/containers`: | |
| ```bash | |
| oc debug node/$(oc get nodes -l disk_type=${disk_type} -o jsonpath='{.items[0].metadata.name}') -- chroot /host /bin/bash -c "df -h /var/lib/containers" | |
| oc get node -l DISK_TYPE=ephemeral -w |
Make sure the device has been mounted correctly to the mount path /var/lib/containers:
oc debug node/$(oc get nodes -l DISK_TYPE=${DISK_TYPE} -o jsonpath='{.items[0].metadata.name}') -- chroot /host /bin/bash -c "df -h /var/lib/containers"Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document steps to benchmark AWS EBS volumes on OCP.