Skip to content

Fixed MediaStreamRecorder audio bug #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevin-frugier wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed MediaStreamRecorder audio bug #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions RecordRTC/RecordRTC.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function RecordRTC(mediaStream, config) {
// html2canvas recording!
if (config.type == 'canvas') Recorder = window.CanvasRecorder;

mediaRecorder = new Recorder(mediaStream);
mediaRecorder = new Recorder(mediaStream, config.type);

// Merge all data-types except "function"
mediaRecorder = mergeProps(mediaRecorder, config);
Expand Down Expand Up @@ -530,13 +530,13 @@ var Storage = {
* Also extract the encoded data and create blobs on every timeslice passed from start function or RequestData function called by UA.
*/

function MediaStreamRecorder(mediaStream) {
function MediaStreamRecorder(mediaStream, type) {
var self = this;

// if user chosen only audio option; and he tried to pass MediaStream with
// both audio and video tracks;
// using a dirty workaround to generate audio-only stream so that we can get audio/ogg output.
if (this.type == 'audio' && mediaStream.getVideoTracks && mediaStream.getVideoTracks().length) {
if (type === 'audio' && mediaStream.getVideoTracks && mediaStream.getVideoTracks().length) {
var context = new AudioContext();
var mediaStreamSource = context.createMediaStreamSource(mediaStream);

Expand Down