Skip to content

Conversation

@mubbi
Copy link
Owner

@mubbi mubbi commented Jul 18, 2025

This pull request introduces several updates, including a bug fix, improved platform independence for port-checking scripts, and minor adjustments to project configuration. The most significant changes focus on enhancing the robustness of port availability checks across different operating systems and ensuring compatibility with various tools.

Bug Fixes

  • Updated the CHANGELOG.md to document a fix for the health check of the queue worker, ensuring it retrieves the correct status. This change is part of version 1.2.1. ([CHANGELOG.mdR3-R10](https://github.com/mubbi/laravel-blog-api/pull/13/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR3-R10))

Platform-Independent Port Checking

  • containers/check-ports.sh:
    • Introduced a detect_os function to determine the operating system and adapt port-checking logic accordingly. ([containers/check-ports.shL29-R98](https://github.com/mubbi/laravel-blog-api/pull/13/files#diff-572807e71f638f397bd52623f306f9b05b8533d0a1e32d2aef2b1a174b99befbL29-R98))
    • Enhanced the check_port function to use appropriate tools (netstat, ss, or nc) based on the detected OS, improving reliability across Windows, macOS, and Linux. ([[1]](https://github.com/mubbi/laravel-blog-api/pull/13/files#diff-572807e71f638f397bd52623f306f9b05b8533d0a1e32d2aef2b1a174b99befbL29-R98), [[2]](https://github.com/mubbi/laravel-blog-api/pull/13/files#diff-572807e71f638f397bd52623f306f9b05b8533d0a1e32d2aef2b1a174b99befbL52-R194))
    • Added a check_requirements function to verify the availability of necessary tools and provide installation instructions if missing. ([containers/check-ports.shL52-R194](https://github.com/mubbi/laravel-blog-api/pull/13/files#diff-572807e71f638f397bd52623f306f9b05b8533d0a1e32d2aef2b1a174b99befbL52-R194))
  • containers/check-sonarqube-ports.sh: Applied similar platform-independent improvements to SonarQube-specific port-checking logic, mirroring changes in check-ports.sh. ([[1]](https://github.com/mubbi/laravel-blog-api/pull/13/files#diff-16a7cd845687dab348ba70cb3becbe067a3cdb2d868a1c8a8708d82c647cda97L20-R88), [[2]](https://github.com/mubbi/laravel-blog-api/pull/13/files#diff-16a7cd845687dab348ba70cb3becbe067a3cdb2d868a1c8a8708d82c647cda97L34-R101), [[3]](https://github.com/mubbi/laravel-blog-api/pull/13/files#diff-16a7cd845687dab348ba70cb3becbe067a3cdb2d868a1c8a8708d82c647cda97R187-R261))

Configuration Updates

  • Incremented the project version from 1.2.0 to 1.2.1 in .release-please-manifest.json. ([.release-please-manifest.jsonL2-R2](https://github.com/mubbi/laravel-blog-api/pull/13/files#diff-e38bb01e41ed5baa3c9e8111b86009ca62d4498d2aefd14d367cd6300dd8b126L2-R2))
  • Adjusted the Makefile to ensure Git hooks are copied correctly by targeting files within the .githooks directory instead of the directory itself. ([MakefileL49-R49](https://github.com/mubbi/laravel-blog-api/pull/13/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L49-R49))

@mubbi mubbi merged commit 5397d38 into develop Jul 18, 2025
2 checks passed
@mubbi mubbi deleted the fix/scripts-automation branch July 18, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants