Fix/scripts makefile #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to streamline Docker-based testing workflows and enhance port-checking scripts for better reliability and clarity. The key changes include improving test container handling in the
Makefileand refining port-checking logic across multiple scripts.Docker-based testing improvements:
testandtest-coveragetargets in theMakefileto check if the test container is already running before setting it up, reducing unnecessary overhead. This change ensures the workflow is more efficient by skipping redundant setup steps when the container is already active.Port-checking logic enhancements:
check_port()function incontainers/check-ports.shandcontainers/check-sonarqube-ports.shto only consider ports in the "LISTEN" state when determining if a port is in use. This change improves accuracy by excluding irrelevant states. [1] [2]return 0statement in thecheck_port()function ofcontainers/check-sonarqube-ports.shto ensure proper early exit when a port is available.