fix(realtime): Use user provided voice and allow pipeline models to have no backend #8415
+74
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
richiejp
commented
Feb 5, 2026
richiejp
commented
- fix(realtime): Use the voice provided by the user or none at all
- fix(ui,config): Allow pipeline models to have no backend and use same validation in frontend
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mudler
previously approved these changes
Feb 5, 2026
|
Verified this locally; it fixes #8413. Great work! |
richiejp
force-pushed
the
fix/realtime-audio
branch
from
417835e to
2f36a2f
Compare
richiejp
force-pushed
the
fix/realtime-audio
branch
3 times, most recently
from
81d9963 to
e437def
Compare
Collaborator
Author
|
moonshine build failure appears to be unrelated? Voxcpm test failure I am not so sure about. |
richiejp
force-pushed
the
fix/realtime-audio
branch
2 times, most recently
from
bf0663f to
f619645
Compare
Owner
yup that seems to hit master as well, still didn't had time to have a look at it why it started failing recently |
richiejp
force-pushed
the
fix/realtime-audio
branch
3 times, most recently
from
546e42a to
6cdf4c7
Compare
Collaborator
Author
|
I had to revert merging the config validation into one function on the backend, but kept in some other fixes I found along the way for that. So now all the test failures appear to be unrelated? Basically I realised that it is possible to load a config with no backend set because we cycle through the backends in that case and I shouldn't have messed with that in this PR anyway. So now we just make sure pipeline models can be validated by the UI. |
Signed-off-by: Richard Palethorpe <[email protected]>
… validation in frontend Signed-off-by: Richard Palethorpe <[email protected]>
Signed-off-by: Richard Palethorpe <[email protected]>
Test fixtures were missing the `backend` field which is now required by the model config validation. Updated all test model configurations to include appropriate backend values. Changes: - Added backend: llama-cpp to test fixtures (embeddings, gpt4, gpt4_2, rwkv, config list entries) - Added backend: llama-cpp to gallery_simple.yaml embedded config - Updated model_config_test.go to expect validation failure for old config format without backend 💘 Generated with Crush Assisted-by: Claude Sonnet 4.5 via Crush <[email protected]> Signed-off-by: Richard Palethorpe <[email protected]>
Signed-off-by: Richard Palethorpe <[email protected]>
Signed-off-by: Richard Palethorpe <[email protected]>
Signed-off-by: Richard Palethorpe <[email protected]>
…not guaranteed Signed-off-by: Richard Palethorpe <[email protected]>
Signed-off-by: Richard Palethorpe <[email protected]>
richiejp
force-pushed
the
fix/realtime-audio
branch
from
6cdf4c7 to
1e3a43c
Compare
mudler
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.