Conversation
…tionlist datatype attribute - enterprise version fix
Member
|
Renaming $attribute to $contentObjectAttribute makes the changes look more involved than they are. I'm +1 on the basis that we also tested this on a client. |
Member
Author
|
ez system pull request: |
Member
|
+1 on the basis of existing enterprise patch + client test + fairly simple changes |
Member
Author
|
This got now merged on upstream: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's how it was fixed in the ez enterprise version. Some code styling isn't correct but I didn't fix it in order to stay as close as possible to what ez system did to fix the issue.
I did some tests, seems to work fine also in a multi-lang setup.