-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
spring_boot_ecommerce/src/main/java/com/sample/ecommerce/order/controller/OrderController.java
Line 23 in b48b207
OrderService service;
Naming should be orderService instead of service
@Builder(toBuilder = true)
Why toBuilder
@Column(name = "status")
Uniform use of @Column(name = "status")
spring_boot_ecommerce/src/main/java/com/sample/ecommerce/order/service/OrderService.java
Line 40 in b48b207
Order order = createOrderfromDto(new Order(), orderDto);
Why do we need to pass empty Order here?
spring_boot_ecommerce/src/main/java/com/sample/ecommerce/order/service/OrderService.java
Line 53 in b48b207
public Order createOrderfromDto(Order order, OrderDto orderDto) {
Should this method be private?
Metadata
Metadata
Assignees
Labels
No labels