[toast] Prevent duplicate onClose calls for ending toasts#4280
Open
chuganzy wants to merge 1 commit intomui:masterfrom
Open
[toast] Prevent duplicate onClose calls for ending toasts#4280chuganzy wants to merge 1 commit intomui:masterfrom
onClose calls for ending toasts#4280chuganzy wants to merge 1 commit intomui:masterfrom
Conversation
chuganzy
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
onClosecould be triggered multiple times when a toast is already in the ending state as pointed out here.