[code-infra] Migrate build command to code-infra #46614

brijeshb42 · 2025-07-28T16:32:51Z

See original PR - mui/mui-public#408 for full context and description.

I have followed (at least) the PR section of the contributing guide.

mui-bot · 2025-07-28T16:34:05Z

Netlify deploy preview

https://deploy-preview-46614--material-ui.netlify.app/

Bundle size report

Bundle	Parsed size	Gzip size
@mui/material	0B^(0.00%)	0B^(0.00%)
@mui/lab	0B^(0.00%)	0B^(0.00%)
@mui/system	0B^(0.00%)	0B^(0.00%)
@mui/utils	0B^(0.00%)	0B^(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against cc3242b

Janpot · 2025-08-13T08:02:24Z

Any idea about the bundle size differences?

Janpot · 2025-08-13T08:03:08Z

babel.config.mjs

@@ -1,24 +1,29 @@
-// @ts-check


Why remove?

Added back. Forgot to copy this into the new file.

Janpot · 2025-08-13T08:04:08Z

packages-internal/scripts/package.json

@@ -3,7 +3,6 @@
  "version": "2.0.12",
  "author": "MUI Team",
  "description": "Utilities supporting MUI libraries build and docs generation. This is an internal package not meant for general use.",
-  "main": "build/index.js",


Doesn't have to part of this scope, but maybe we could do some "package.json linting" in our build step? To error or warn on things like this?

I do linting for exports field right now (the one without *). main field is anyways overwritten based on the presence of build/index.js.
But I agree, we can always add more checks, even for the ones with *.

yes, I mean if it's overwritten, we may as well just warn at least

Noted. Will add in code-infra.

Janpot · 2025-08-13T08:06:05Z

scripts/build.mjs

@@ -55,7 +55,7 @@ async function run(argv) {
    );
  }

-  const babelConfigPath = path.resolve(getWorkspaceRoot(), 'babel.config.js');
+  const babelConfigPath = path.resolve(getWorkspaceRoot(), 'babel.config.mjs');


Will we still need scripts/build.mjs?

I've kept it for now. Once all the repo PRs are merged, we can delete it in a separate PR.

but these may not necessarily have babel.config.mjs yet

brijeshb42 · 2025-08-13T08:55:06Z

Any idea about the bundle size differences?

This is the last blocker that I am investigating currently.

brijeshb42 · 2025-08-13T14:50:16Z

@Janpot All issues have been fixed.

Janpot

Awesome

siriwatknp

👍 Tested with the PR release packages, works fine.

brijeshb42 added the scope: code-infra Changes related to the core-infra product. label Jul 28, 2025

brijeshb42 force-pushed the migrate-build branch 2 times, most recently from 122ca48 to 6435e26 Compare July 31, 2025 14:55

brijeshb42 mentioned this pull request Jul 31, 2025

[code-infra] Migrate build command mui/mui-public#408

Merged

2 tasks

brijeshb42 force-pushed the migrate-build branch 2 times, most recently from 0e5759f to dd11aaa Compare August 1, 2025 11:32

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 1, 2025

brijeshb42 force-pushed the migrate-build branch from dd11aaa to 94bc1f3 Compare August 7, 2025 11:32

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 7, 2025

brijeshb42 force-pushed the migrate-build branch 5 times, most recently from c7e7703 to 18e6a1b Compare August 11, 2025 06:37

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 11, 2025

brijeshb42 force-pushed the migrate-build branch from 18e6a1b to e0c9988 Compare August 11, 2025 10:29

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 11, 2025

brijeshb42 force-pushed the migrate-build branch from e0c9988 to 44169ac Compare August 11, 2025 11:09

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 11, 2025

brijeshb42 force-pushed the migrate-build branch from 44169ac to 7c32acb Compare August 11, 2025 15:29

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 11, 2025

brijeshb42 force-pushed the migrate-build branch 3 times, most recently from 65484d7 to 953ff45 Compare August 11, 2025 17:14

brijeshb42 marked this pull request as ready for review August 11, 2025 17:32

brijeshb42 requested a review from a team August 11, 2025 17:32

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 12, 2025

brijeshb42 force-pushed the migrate-build branch from 953ff45 to ed0cdfa Compare August 12, 2025 09:40

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 12, 2025

brijeshb42 force-pushed the migrate-build branch 2 times, most recently from 3419612 to 11c0241 Compare August 12, 2025 10:10

Janpot reviewed Aug 13, 2025

View reviewed changes

brijeshb42 force-pushed the migrate-build branch 3 times, most recently from d5c148f to a59b6f1 Compare August 13, 2025 09:01

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 13, 2025

brijeshb42 force-pushed the migrate-build branch from a59b6f1 to 816ab59 Compare August 13, 2025 12:35

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 13, 2025

brijeshb42 force-pushed the migrate-build branch 2 times, most recently from 5671f7e to 900ef81 Compare August 13, 2025 14:33

Janpot approved these changes Aug 13, 2025

View reviewed changes

brijeshb42 mentioned this pull request Aug 13, 2025

[code-infra] Remove @mui/envinfo dependency on fs-extra #46741

Closed

[infra] Migrate build command to code-infra

cc3242b

brijeshb42 force-pushed the migrate-build branch from 900ef81 to cc3242b Compare August 13, 2025 17:32

brijeshb42 requested a review from Janpot August 14, 2025 05:21

brijeshb42 mentioned this pull request Aug 14, 2025

[code-infra] Lint package.json entrypoints like main/module etc mui/mui-public#503

Closed

siriwatknp approved these changes Aug 14, 2025

View reviewed changes

Janpot approved these changes Aug 14, 2025

View reviewed changes

brijeshb42 merged commit d632373 into mui:master Aug 14, 2025
19 checks passed

oliviertassinari changed the title ~~[infra] Migrate build command to code-infra~~ [code-infra] Migrate build command to code-infra Aug 15, 2025

Uh oh!

[code-infra] Migrate build command to code-infra #46614

[code-infra] Migrate build command to code-infra #46614

Uh oh!

Conversation

brijeshb42 commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mui-bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Netlify deploy preview

Bundle size report

Uh oh!

Janpot commented Aug 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brijeshb42 commented Aug 13, 2025

Uh oh!

brijeshb42 commented Aug 13, 2025

Uh oh!

Janpot left a comment

Choose a reason for hiding this comment

Uh oh!

siriwatknp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

brijeshb42 commented Jul 28, 2025 •

edited

Loading

mui-bot commented Jul 28, 2025 •

edited

Loading