[material-ui][TimelineItem] Fix extra ::before spacing when TimelineOppositeContent is present #46663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-46663--material-ui.netlify.app/ Bundle size report
|
tyalau
force-pushed
the
fix/timelineitem-extra-space
branch
2 times, most recently
from
0536f73 to
505434c
Compare
ZeeshanTamboli
added
breaking change
tyalau
force-pushed
the
fix/timelineitem-extra-space
branch
from
505434c to
f760873
Compare
ZeeshanTamboli
changed the title
tyalau
force-pushed
the
fix/timelineitem-extra-space
branch
from
f760873 to
0a3eb16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46639
Summary
This PR updates the logic to use a pure CSS approach by leveraging the
:has()and:not()selectors. The::beforestyling is now applied only when.MuiTimelineOppositeContent-rootis not present within aTimelineItem.This ensures consistent layout behavior regardless of whether TimelineItem is used in a Server or Client Component.
useEffect()is used to check children after hydration and sethasOppositeContentaccordingly, which is then used to conditionally apply themissingOppositeContentclass.