Skip to content

[utils] Remove duplicate isHostComponent function #46721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2025
Merged

[utils] Remove duplicate isHostComponent function #46721

merged 2 commits into from
Aug 13, 2025

Conversation

frontman-git
Copy link
Contributor

@frontman-git frontman-git commented Aug 12, 2025 •
edited
Loading

Fixes #46709

Summary

@mui-bot
Copy link

mui-bot commented Aug 12, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-46721--material-ui.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/material ▼-41B(-0.01%) ▼-10B(-0.01%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 15e0957

@zannager zannager added performance internal Behind-the-scenes enhancement. Formerly called “core”. labels Aug 12, 2025
@zannager zannager requested a review from siriwatknp August 12, 2025 10:50
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui] dedupe isHostComponent function [core] Cleanup isHostComponent function duplication Aug 13, 2025
@ZeeshanTamboli ZeeshanTamboli added the scope: all components Widespread work has an impact on almost all components. label Aug 13, 2025
ZeeshanTamboli
ZeeshanTamboli approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frontman-git Thanks for the cleanup.

@ZeeshanTamboli ZeeshanTamboli changed the title [core] Cleanup isHostComponent function duplication [utils] Remove duplicate isHostComponent function Aug 13, 2025
@ZeeshanTamboli ZeeshanTamboli merged commit 882adb4 into mui:master Aug 13, 2025
22 checks passed
@oliviertassinari oliviertassinari added the package: utils Specific to the utils package. label Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
internal Behind-the-scenes enhancement. Formerly called “core”. package: utils Specific to the utils package. performance scope: all components Widespread work has an impact on almost all components.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[all components] Clean-up isHostComponent() duplication
5 participants
@frontman-git @mui-bot @ZeeshanTamboli @oliviertassinari @zannager