Skip to content

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 12, 2025

Since #46483 we have the setting shared, but I think we are better of making the schedule specific to each repository

Looking at the history, we haven't been consistent enough to run this update: https://github.com/mui/material-ui/pulls?q=is%3Apr+%22Lock+file+maintenance%22+is%3Aclosed. Which seems to be why we have so many of those: https://github.com/mui/material-ui/security/dependabot.

@oliviertassinari oliviertassinari added internal Behind-the-scenes enhancement. Formerly called “core”. type: regression A bug, but worse, it used to behave as expected. scope: code-infra Changes related to the core-infra product. labels Aug 12, 2025
@mui-bot
Copy link

mui-bot commented Aug 12, 2025

Fails
🚫

node failed.

Netlify deploy preview

https://deploy-preview-46727--material-ui.netlify.app/

Log

danger-results://tmp/danger-results-74732542.json

Generated by 🚫 dangerJS against 95f97e2

@oliviertassinari

This comment was marked as resolved.

@oliviertassinari oliviertassinari added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. and removed type: regression A bug, but worse, it used to behave as expected. labels Aug 12, 2025
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 17, 2025

I'm merging, it's a simple one, each time renovate update the deps of a repository, it does it with prConcurrentLimit = 30. But:

  • In CircleCI, all our GitHub repositories uses the same Circle CI org, on average a PR creates 5 CircleCI tasks. CircleCI has a maximum concurrency of 80. So one repository is enough to starve CircleCI.
  • Netlify, all our GitHub repositories uses the same Netlify org. Netlify has a maximum concurrency of 5. So one repository is enough to starve Netlify.

So we need each repository to set a different schedule.


Also, it says that the natural language syntax is deprecated https://docs.renovatebot.com/configuration-options/#schedule, it should use the cron on:

Config support questions are no longer accepted for Later syntax problems - you will be recommended to use Cron instead

@oliviertassinari oliviertassinari changed the title [internal] Add lockFileMaintenance back [internal] Polish renovate schedule Aug 17, 2025
@oliviertassinari oliviertassinari merged commit 9c5220e into mui:master Aug 17, 2025
6 of 15 checks passed
@oliviertassinari oliviertassinari deleted the lockFileMaintenance branch August 17, 2025 21:55
oliviertassinari added a commit to mui/mui-public that referenced this pull request Aug 17, 2025
oliviertassinari added a commit to mui/mui-x that referenced this pull request Aug 17, 2025
oliviertassinari added a commit to mui/base-ui that referenced this pull request Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Behind-the-scenes enhancement. Formerly called “core”. scope: code-infra Changes related to the core-infra product. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants