[autocomplete] Fix ArrowLeft crash when value is not set with single-value rendering #47214
+44
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd unit test cases
Netlify deploy previewhttps://deploy-preview-47214--material-ui.netlify.app/ Bundle size report
|
ZeeshanTamboli
added
type: bug
Ensure focus is only attempted when value exists in ArrowLeft handler Remove optional chaining as it's not needed after null check
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
rithik56
changed the title
Member
Contributor
Author
|
Yes @ZeeshanTamboli. Will do this |
Contributor
Author
|
@ZeeshanTamboli I tried pushing the empty commit but the CI is not getting triggered |
Member
|
Hmm, I tried again but those two particular CI jobs aren't running. |
ZeeshanTamboli
approved these changes
Nov 11, 2025
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
@rithik56 We re-tried the netlify build+cleared the cache and the CI is passing now. I had made a few changes in the code. Looks good now. Thanks for the pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47212
fix(Autocomplete): prevent error when focusing non-existent element
Add optional chaining when focusing elements in useAutocomplete to handle cases where the element doesn't exist. Add tests to verify the behaviour